- From: Keith Cirkel <notifications@github.com>
- Date: Wed, 11 Oct 2023 02:26:18 -0700
- To: whatwg/dom <dom@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 11 October 2023 09:26:23 UTC
@keithamus commented on this pull request. > + <li>If <var>theParent</var> is equal to <var>internals</var>' <a + for=EventTargetInternals>eventTarget</a> then <a>throw</a> a + "{{HierarchyRequestError!!exception}}" {{DOMException}}. + + <li>If <var>theParent</var>'s <a for=EventTarget>attached internals</a> + {{EventTargetInternals/parent}} is equal to <var>internals</var>' <a + for=EventTargetInternals>eventTarget</a> then<a>throw</a> a "{{HierarchyRequestError!!exception}}" + {{DOMException}}. By providing steps to set the parent I also squeezed in a couple more early checks where we can assert that there aren't circular references going on. -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/dom/pull/1230#pullrequestreview-1670595210 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/dom/pull/1230/review/1670595210@github.com>
Received on Wednesday, 11 October 2023 09:26:23 UTC