- From: Anne van Kesteren <notifications@github.com>
- Date: Mon, 02 Oct 2023 06:51:49 -0700
- To: whatwg/fetch <fetch@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/fetch/issues/1715@github.com>
Feedback on #1647 to keep the overall PR in terms of comments and such somewhat smaller in size. - [ ] Put the new method under the existing "Fetch method" heading, but rename it to "Fetch methods". "Fetch" in this heading is not a reference to `fetch()`, but to the fact that the method can fetch. So "FetchLater method" doesn't make a whole lot of sense in that light. - [ ] `FetchLaterResult` needs to be `[Exposed]`. - [ ] User agent is without hyphen, see Infra. - [ ] "Not allowed in this context" is woefully vague. Can we do better or even agree on a model here? - [ ] If the exceptions are meant to be `DOMException` that should follow the style for them. - [ ] "This may throw an exception." we generally don't state this. - [ ] "If request’s [URL](https://whatpr.org/fetch/1647.html#concept-request-url) is not a [potentially trustworthy url](https://w3c.github.io/webappsec-secure-contexts/#potentially-trustworthy-url)," This is a Mixed Content consideration and should be caught by the network layer, not the API. - [ ] "[exists](https://infra.spec.whatwg.org/#map-exists) then" missing comma. - [ ] "[DOMHighResTimeStamp](https://w3c.github.io/hr-time/#dom-domhighrestimestamp) then" missing comma. - [ ] "0 then" missing comma. - [ ] Why is deferred fetch record defined as part of fetch groups? Just looking at the Fetch groups section it sticks out a bit in a weird way. - [ ] Why are some request body checks made inside `fetchLater()` and some inside "request a deferred fetch"? - [ ] "The user agent may [process deferred fetches](https://whatpr.org/fetch/1647.html#process-deferred-fetches) at any given moment" This seems wrong? I suppose it's only when the browser expects that the fetch groups will die? (Unfortunately fetch groups are not well-defined...) -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/fetch/issues/1715 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/fetch/issues/1715@github.com>
Received on Monday, 2 October 2023 13:51:56 UTC