- From: Thiago Perrotta <notifications@github.com>
- Date: Tue, 21 Nov 2023 07:43:19 -0800
- To: w3c/permissions <permissions@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Tuesday, 21 November 2023 15:43:24 UTC
@thiagowfx commented on this pull request.
> + permissions.SetPermissionParameters = {
+ descriptor: permissions.PermissionDescriptor,
+ state: permissions.PermissionState,
+ }
+ </pre>
+ </dd>
+ <dt>Result Type</dt>
+ <dd>
+ <pre class="cddl">
+ EmptyResult
+ </pre>
+ </dd>
+ </dl>
+ <ol algorithm="remote end steps for permissions.setPermission">
+ <p>
+ TODO: Add user <code>context</code> to <code>SetPermissionParameters</code>.
I am fine to remove the TODOs here. The reason I added them in the first place was the precedent on the BiDi spec itself: https://w3c.github.io/webdriver-bidi/ -- it currently has 16 TODOs.
But of course, if the Permissions spec doesn't follow this convention, we can just keep track of them in the Issues.
--
Reply to this email directly or view it on GitHub:
https://github.com/w3c/permissions/pull/425#discussion_r1400797492
You are receiving this because you are subscribed to this thread.
Message ID: <w3c/permissions/pull/425/review/1742347613@github.com>
Received on Tuesday, 21 November 2023 15:43:24 UTC