Re: [w3c/permissions] Introduce Browser Permissions for WebDriver BiDi (PR #425)

@miketaylr commented on this pull request.

Noting that if you were to place WebDriver-Bidi after WebDriver, this would be a bit easier to review.

Also, can you fix the build errors?

>        </p>
       <pre class='idl'>
         dictionary PermissionSetParameters {
           required PermissionDescriptor descriptor;
           required PermissionState state;
         };
       </pre>
-      <section>
-        <h3 id="set-permission-command">
-          Set Permission
+      <section data-cite="webdriver-bidi webdriver">
+        <h3 id="automation-webdriver-bidi">
+          Automated testing with [[WebDriver-BiDi]]

nit: Why would WebDriver-Bidi come before WebDriver? If I were sorting them lexicographically, I would place WebDriver first. The diff would be a lot easier to review as well.

>          <p>
-          The <dfn class="export" data-dfn-for="extension commands">Set Permission</dfn>
-          <a>extension command</a> simulates user modification of a {{PermissionDescriptor}}'s
-          <a>permission state</a>.
+          This document defines the following [=extension modules=] for the [[WebDriver-BiDi]] specification.

It seems like this dfn is not exported.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/permissions/pull/425#pullrequestreview-1721319510
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/permissions/pull/425/review/1721319510@github.com>