Re: [w3c/clipboard-apis] Add `unsanitized` option to async clipboard API. (PR #197)

@sanketj requested changes on this pull request.



>  
    1. Let |realm| be [=this=]'s [=relevant realm=].
 
    1. Let |p| be [=a new promise=] in |realm|.
 
+   1. Let |format| be a {{DOMString}}.

Shouldn't |formats| be a dictionary instead of just a DOMString?

> @@ -841,7 +861,11 @@ url: https://w3c.github.io/permissions/#permissions-task-source; type: dfn;
 
        Issue: It should be possible to read the data asynchronously from the system clipboard after the author calls getType, however, this set of steps implies that data will be provided at the time of read.
       
-      1. The user agent, MAY sanitize |representation|'s [=representation/data=], unless |representation|'s [=representation/MIME type=]'s essence is "image/png", which should remain unsanitized to preserve meta data.
+      1. The user agent, MAY sanitize |representation|'s [=representation/data=], unless it satisfies the below conditions:
+      
+       1. |representation|'s [=representation/MIME type=]'s [=MIME type/essence=] is "image/png", which should remain unsanitized to preserve meta data.
+       
+       1. If |format| is not empty and |representation|'s [=representation/MIME type=]'s [=MIME type/essence=] is equal to |format|.

Is this trying to say that the representation's MIME type is amongst the formats inside the sequence of `DOMString`s, which is named `unsanitized`? https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/clipboard/clipboard.idl;l=1?q=clipboard.idl&sq=&ss=chromium

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/clipboard-apis/pull/197#pullrequestreview-1709471763
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/clipboard-apis/pull/197/review/1709471763@github.com>