Re: [whatwg/streams] TransformStream cleanup using "Transformer.cancel" (PR #1283)

@saschanaz approved this pull request.

Nothing looks obviously off, which means, LGTM.

For the test part, could we replace `await delay(0);` with something else?

>    1. If |flushPromise| was fulfilled, then:
-   1. If |readable|.[=ReadableStream/[[state]]=] is "`errored`", throw
-      |readable|.[=ReadableStream/[[storedError]]=].
-   1. Perform !
-      [$ReadableStreamDefaultControllerClose$](|readable|.[=ReadableStream/[[controller]]=]).
+   1. Perform ! [$ReadableStreamDefaultControllerClose$](|readable|.[=ReadableStream/[[controller]]=]).
+   1. [=Resolve=] |controller|.[=TransformStreamDefaultController/[[finishPromise]]=] with undefined.

(At the first glance it looked like it was ignoring the error, but in that case it would have finishPromise and thus would return at the above check.)

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/1283#pullrequestreview-1503006252
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/streams/pull/1283/review/1503006252@github.com>