- From: meacer <notifications@github.com>
- Date: Wed, 21 Jun 2023 16:50:00 -0700
- To: whatwg/fetch <fetch@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/fetch/pull/1655/review/1492092356@github.com>
@meacer commented on this pull request. > + fallback request that shouldn't be upgraded again. Clear the <code>https-upgrade</code> and + <code>https-upgrade-fallback-url</code> flags and return <var>request</var>.</li> + + <li><p>Otherwise, upgrade the request by setting the following fields: + <ul> + <li>Set <code>https-upgrade-fallback-url</code> to request's URL</li> + <li>Set <var>request</var>'s URL's scheme to <code>"https"</code></li> + <li>Set <code>https-upgrade</code> flag to true</li> + </ul> + </li> +</ol> + +<h4 id=https-upgrades-fallback>Fallback algorithm</h4> + +<p>Runs after the Upgrade algorithm. This algorithm determines whether the upgraded +request completed without a network error. If not, it retries the request over <code>"http"</code>. > On top of that, you want to explicitly run this algorithm, rather than saying when it should be run. Line 5301 explicitly runs this algorithm, was that what you meant? I can also remove the "Runs after the Upgrade algorithm" sentence here altogether. -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/fetch/pull/1655#discussion_r1237832121 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/fetch/pull/1655/review/1492092356@github.com>
Received on Wednesday, 21 June 2023 23:50:06 UTC