Re: [whatwg/webidl] Editorial: Handle exceptions thrown while converting 'invoke's return value. (PR #1323)

@domenic approved this pull request.

(Note for when we merge: bugfixes aren't editorial.)

Happy to merge this as-is or with the additional fix I suggested. Thanks for finding it.

In practice, I suspect most cases where these algorithms are invoked, do not have return types where a conversion would fail. That is, most callback function types are void or something easy to convert to (e.g. boolean). I wonder which specs, if any, have more restrictive return types in such cases, and whether they're prepared to handle such conversion failures.

> @@ -14186,7 +14186,8 @@ the special value “missing”, which represents a missing optional argument.
         |callResult| and jump to the step labeled <a href="#call-user-object-operation-return"><i>return</i></a>.
     1.  Set |completion| to the result of [=converted to an IDL value|converting=]
         |callResult|.\[[Value]] to an IDL value of the same type as the operation's

While here, maybe fix this to not say "operation's" for all three, and instead reference _callable_'s return type where appropriate?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/webidl/pull/1323#pullrequestreview-1489502731
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/webidl/pull/1323/review/1489502731@github.com>