- From: Luca Casonato <notifications@github.com>
- Date: Mon, 12 Jun 2023 11:23:41 -0700
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Monday, 12 June 2023 18:23:47 UTC
@lucacasonato commented on this pull request.
> + <p>(Note that there is no need to call
+ {{TransformStreamDefaultController/terminate()|controller.terminate()}} inside
+ {{Transformer/cancel|cancel()}}; the stream is already in the process of cancelling/aborting, and
+ terminating it would be counterproductive.)
+
My train of thought is that you could extract the `controller` in `start` and assign it to a local variable.
--
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/1283#discussion_r1227075285
You are receiving this because you are subscribed to this thread.
Message ID: <whatwg/streams/pull/1283/review/1475551822@github.com>
Received on Monday, 12 June 2023 18:23:47 UTC