- From: Luca Casonato <notifications@github.com>
- Date: Sat, 10 Jun 2023 13:35:57 -0700
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Saturday, 10 June 2023 20:36:03 UTC
I don't particularly like `dispose`, as it implies it is called both on successful and errored close (because that is what `Symbol.dispose` does. This however is only called on the error case, because successful disposal is already handled through `flush`. I think we need something that implies early _unsuccessful_ termination. `abort` and `cancel` fit the bill here, except that we already use them elsewhere so using the same word may be confusing. I'm not super strongly concerned with confusion here tho, as the use case is very similar to those hooks in RS and WS. -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/streams/pull/1283#issuecomment-1585811166 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/streams/pull/1283/c1585811166@github.com>
Received on Saturday, 10 June 2023 20:36:03 UTC