Re: [whatwg/fetch] HTTPS upgrades proposal (PR #1655)

@christhompson commented on this pull request.



> +<p>Given a request <var>request</var>, this algorithm will rewrite its URL if the request should be
+modified and loaded over <code>"https"</code>, via the following algorithm:
+
+<ol>
+  <li>
+    <p>If one or more of the following conditions are met, return without modifying request:
+    <ul>
+      <li><p><var>request</var> is not a navigation request whose destination is document</li>
+
+      <li><p><var>request</var>'s method is not `<code>GET</code>`</li>
+
+      <li><p><var>request</var>'s URL's scheme is not <code>"http"</code></li>
+
+      <li><p><var>request</var>'s URL's host is non-unique (i.e., contains a non-registrable or
+      non-assignable domain name such as .local or an IP address that falls in a range reserved for
+      non-publicly routable networks)</li>

This is another case where it might be better to just have a per-UA carveout (implementation-defined) for exempting certain hostnames from upgrading (Line 3271 below) which would subsume this.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1655#discussion_r1223368723
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/fetch/pull/1655/review/1470484051@github.com>

Received on Thursday, 8 June 2023 17:47:35 UTC