Re: [whatwg/webidl] Allow DOMException subclasses to be used as exceptions (PR #1211)

@domenic commented on this pull request.



> +
+          readonly attribute unsigned long long errorCode;
+        };
+
+        dictionary ProtocolXErrorOptions {
+            required [EnforceRange] unsigned long long errorCode;
+        };
+    </pre>
+
+    Every <code>ProtocolXError</code> instance has an <dfn for="ProtocolXError">error code</dfn>,
+    a number.
+
+    <div algorithm="ProtocolXError constructor">
+        The <b><code>new ProtocolXError(|message|, |options|)</code></b> constructor steps are:
+
+        1.  Set [=this=]'s [=DOMException/name=] to "<code>ProtocolXError</code>".

No. We need to reference the internal slots (`[=DOMException/name=]`); you cannot set public getters (`{{DOMException/name}}`) to values.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/webidl/pull/1211#discussion_r1213816485
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/webidl/pull/1211/review/1456514012@github.com>

Received on Friday, 2 June 2023 01:16:00 UTC