Re: [whatwg/xhr] Add optional submitter argument to FormData constructor (PR #366)

@annevk commented on this pull request.



> @@ -1609,7 +1609,7 @@ typedef (File or USVString) FormDataEntryValue;
 
 [Exposed=(Window,Worker)]
 interface FormData {
-  constructor(optional HTMLFormElement form);
+  constructor(optional HTMLFormElement form, optional HTMLElement? submitter = null);

Found a nit after all. Is there a good reason to allow null here? Or would requiring undefined by fine? If there's no use case for passing null we should not allow it and change the language below from "is non-null" to "is given".

(And then have an additional test that null throws.)

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/xhr/pull/366#pullrequestreview-1269835519
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/xhr/pull/366/review/1269835519@github.com>