- From: Trevor Rowbotham <notifications@github.com>
- Date: Mon, 23 Jan 2023 16:31:14 -0800
- To: whatwg/url <url@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Tuesday, 24 January 2023 00:31:27 UTC
@TRowbotham commented on this pull request. > @@ -1031,13 +1368,14 @@ actually doing that with the editors of this document first. <li> <p>If <var>ipv4Piece</var> is null, then set <var>ipv4Piece</var> to <var>number</var>. - <p>Otherwise, if <var>ipv4Piece</var> is 0, <a>validation error</a>, return failure. + <p>Otherwise, if <var>ipv4Piece</var> is 0, <a>IPv4-in-IPv6-invalid-first-part</a> Good catch. Perhaps changing the name to something like "IPv4-in-IPv6-leading-zero" or "leading-zero-in-IPv4-part-in-IPv6" -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/url/pull/502#discussion_r1084708522 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/url/pull/502/review/1266640126@github.com>
Received on Tuesday, 24 January 2023 00:31:27 UTC