- From: Kagami Sascha Rosylight <notifications@github.com>
- Date: Mon, 23 Jan 2023 06:03:10 -0800
- To: whatwg/fetch <fetch@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/fetch/pull/1593/review/1265654196@github.com>
@saschanaz commented on this pull request. > + <li>Let <var>bytes</var> be the result of extracting |extractSize| of bytes from + <var>buffer</var>. + + <li>If |stream|s [=ReadableStream/current BYOB request view=] is non-null, then + [=ArrayBufferView/write=] |bytes| into |stream|'s [=ReadableStream/current BYOB request view=], + and set |view| to |stream|'s [=ReadableStream/current BYOB request view=]. <li>Otherwise, set + |view| to the result of [=ArrayBufferView/create|creating=] a {{Uint8Array}} from |bytes| in + |stream|'s [=relevant Realm=]. + + <li>[=ReadableStream/Enqueue=] |view| into |stream|. + + <li><p>If |stream| is [=ReadableStream/errored=], then [=fetch controller/terminate=] + |fetchParams|'s [=fetch params/controller=]. + + <li><p>If |stream| doesn't [=ReadableStream/need more data=], ask the user agent to + [=fetch/suspend=] the ongoing fetch. Actually I instead moved this step back to the fetching algorithm and made it to sleep if the buffer becomes larger than a user-agent defined limit. I think that works too? (It's me who just don't want to describe about the network layer which is not exactly in my area) -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/fetch/pull/1593#discussion_r1084095745 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/fetch/pull/1593/review/1265654196@github.com>
Received on Monday, 23 January 2023 14:03:22 UTC