Re: [whatwg/url] Redo validation errors in the IPv4 parser (PR #739)

@domenic approved this pull request.

LGTM. These action-at-a-distance validation errors are going to be kind of a pain in the implementation (there's no object passed to the host/IPv4/IPv6 parsers to thread them back to), but I think that's best left as an implementation problem.

>  
-<ol>
- <li>
-  <p>Let <var>validationError</var> be false.
-
-  <p class=note>This uses <var>validationError</var> to track <a>validation errors</a> to avoid
-  reporting them before we are confident we want to parse <var>input</var> as an IPv4 address as the
-  <a>host parser</a> almost always invokes the <a>IPv4 parser</a>.
+<p class=note>The <a for=/>IPv4 parser</a> is not to be invoked directly. Instead check that the
+return value of the <a for=/>host parser</a> is an <a for=/>IPv4 address</a>.

I don't understand why IPv4 and IPv6 would be different...

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/url/pull/739#pullrequestreview-1261713811
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/url/pull/739/review/1261713811@github.com>