Re: [whatwg/dom] Add declarative Shadow DOM features (#892)

> I put your build fixes in #1143 and rebased this. I also pushed a fixup commit to correct a number of references to shadow root, adopt some modern practices and address a nit. Improving "allow declarative shadow roots" is left still.

Thanks. As for making "allow declarative shadow roots" non-tri-state, the problem I wanted to avoid was finding all of the places where a `create-the-document-object` is used, and instead defer the decision to the parser. That's how I implemented it in code, and it felt quite a bit simpler than always initializing the document correctly.

Perhaps @rniwa can weigh in on how he implemented this in WebKit? 

> 
> Adding `<div algorithm>` also uncovered an error. "attach a shadow root" didn't account for the addition of "slot assignment". It's probably best if you address that? To make sure it's good for all callers.

Thanks - fixed.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/892#issuecomment-1396281006
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/dom/pull/892/c1396281006@github.com>