Re: [whatwg/url] Should protocol setter remove tabs and newline? (#609)

#61 added the tests in OP, but #101 was fixed before that and somehow not taken into account. So it seem this was an oversight.

I don't think there is an inconsistency between the tests @achristensen07 points towards. There are different requirements for `Location`'s `protocol` setter after all. In particular, the resulting scheme has to be an HTTP(S) scheme as nothing else really gives sensible results there.

I created https://github.com/web-platform-tests/wpt/pull/38032 to update the incorrect tests and add some missing scenarios. Suggestions welcome.

Once those are reviewed I'll file implementation bugs and then we can close this issue in my opinion.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/url/issues/609#issuecomment-1386832436
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/url/issues/609/1386832436@github.com>

Received on Wednesday, 18 January 2023 10:34:06 UTC