- From: Anne van Kesteren <notifications@github.com>
- Date: Fri, 13 Jan 2023 03:41:05 -0800
- To: whatwg/fetch <fetch@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/fetch/pull/1485/review/1247495508@github.com>
@annevk commented on this pull request.
> @@ -4189,16 +4191,20 @@ the request.
<ol>
<li><p>Let <var>value</var> be `<code>*/*</code>`.
+
This has a newline too many.
> @@ -1296,6 +1296,8 @@ downloads. This format of range header value can be set using <a>add a range hea
<a>implementation-defined</a> <a for=/>header value</a> for the `<code>User-Agent</code>`
<a for=/>header</a>.
+<p>The <dfn>Document `Accept` header value</dfn> is
I'm not sure how this was resolved?
> + <p>Otherwise, user agent should set <var>value</var> to the first matching statement, if any,
+ switching on <var>request</var>'s <a for=request>destination</a>:
This also doesn't seem to be actually resolved?
> @@ -1296,6 +1296,8 @@ downloads. This format of range header value can be set using <a>add a range hea
<a>implementation-defined</a> <a for=/>header value</a> for the `<code>User-Agent</code>`
<a for=/>header</a>.
+<p>The <dfn>document `<code>Accept</code>` header value</dfn> is
+`<code>text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8</code>`.
This is still missing.
--
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1485#pullrequestreview-1247495508
You are receiving this because you are subscribed to this thread.
Message ID: <whatwg/fetch/pull/1485/review/1247495508@github.com>
Received on Friday, 13 January 2023 11:41:17 UTC