Re: [whatwg/dom] Correct MutationObserver ownership story (PR #1160) from François REMY on 2023-02-16 (public-webapps-github@w3.org from February 2023)

From: François REMY <notifications@github.com>
Date: Thu, 16 Feb 2023 06:50:41 -0800
To: whatwg/dom <dom@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <whatwg/dom/pull/1160/review/1301601706@github.com>

@FremyCompany commented on this pull request.

I will admit I had no recollection of our previous discussion, but after reviewing your change, I think it makes sense. That way, only pending MutationObserver instances are held strongly by the document. All the others get automatically collected when all the elements they are attached to leave the document.

PS: This review will show as a comment as I do not appear to have the rights to mark the PR "Approved" directly, but I think this can likely go ahead.



-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/1160#pullrequestreview-1301601706
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/dom/pull/1160/review/1301601706@github.com>

Received on Thursday, 16 February 2023 14:50:53 UTC