- From: Domenic Denicola <notifications@github.com>
- Date: Tue, 14 Feb 2023 22:42:15 -0800
- To: whatwg/fetch <fetch@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 15 February 2023 06:42:29 UTC
@domenic approved this pull request. LGTM with nit > + + <li><p>Let |desiredSize| be |available|. + + <li><p>If |stream|'s [=ReadableStream/current BYOB request view=] is non-null, then set + |desiredSize| to |stream|'s [=ReadableStream/current BYOB request view=]'s [=BufferSource/byte + length=]. + + <li><p>Let |extractSize| be the smaller value of |available| and |desiredSize|. + + <li><p>Let <var>bytes</var> be the result of extracting |extractSize| of bytes from + <var>buffer</var>. + + <li>If |stream|s [=ReadableStream/current BYOB request view=] is non-null, then + [=ArrayBufferView/write=] |bytes| into |stream|'s [=ReadableStream/current BYOB request + view=], and set |view| to |stream|'s [=ReadableStream/current BYOB request view=]. + <li>Otherwise, set |view| to the result of [=ArrayBufferView/create|creating=] a Missing newline here -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/fetch/pull/1593#pullrequestreview-1298885504 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/fetch/pull/1593/review/1298885504@github.com>
Received on Wednesday, 15 February 2023 06:42:29 UTC