- From: Marcos Cáceres <notifications@github.com>
- Date: Wed, 08 Feb 2023 19:02:18 -0800
- To: w3c/gamepad <gamepad@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 9 February 2023 03:02:30 UTC
@marcoscaceres commented on this pull request. > </li> <li>Set [=this=].{{GamepadHapticActuator/[[playingEffectPromise]]}} to `undefined`. </li> + <li>[=Queue a global task=] on the [=relevant global object=] + of [=this=] using the [=gamepad task source=] to [=resolve=] + |effectPromise| with {{GamepadHapticsResult/"preempted"}}. + </li> This code path ends with promise being resolved, right? ```suggestion </li> <li>Terminate this algorithm.</li> ``` -- Reply to this email directly or view it on GitHub: https://github.com/w3c/gamepad/pull/182#pullrequestreview-1290363470 You are receiving this because you are subscribed to this thread. Message ID: <w3c/gamepad/pull/182/review/1290363470@github.com>
Received on Thursday, 9 February 2023 03:02:30 UTC