- From: Jeremy Roman <notifications@github.com>
- Date: Wed, 20 Dec 2023 08:13:44 -0800
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 20 December 2023 16:13:52 UTC
@jeremyroman commented on this pull request.
> @@ -6895,8 +6895,8 @@ to grow organically as needed.
otherwise. If this throws an exception |e|, return [=a promise rejected with=] |e|.
1. If |result| is a {{Promise}}, then return |result|.
1. Return [=a promise resolved with=] undefined.
- 1. Let |cancelAlgorithmWrapper| be an algorithm that runs these steps:
- 1. Let |result| be the result of running |cancelAlgorithm|, if |cancelAlgorithm| was given, or
+ 1. Let |cancelAlgorithmWrapper| be an algorithm that runs these steps given |reason|:
+ 1. Let |result| be the result of running |cancelAlgorithm| given |reason|, if |cancelAlgorithm| was given, or
[CONTRIBUTING.md in this repository](https://github.com/whatwg/streams/blob/main/CONTRIBUTING.md#:~:text=Spec%20editorial%20conventions-,Wrap%20lines%20to%20120%20columns.,-\(This%20is%20not) says the line limit in this specification is 120 chars, unlike other WHATWG repositories.
Should I comply with that right now, or do you still want this wrapped at 100?
--
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/1300#discussion_r1432916516
You are receiving this because you are subscribed to this thread.
Message ID: <whatwg/streams/pull/1300/review/1791241464@github.com>
Received on Wednesday, 20 December 2023 16:13:52 UTC