- From: Gabriel Brito <notifications@github.com>
- Date: Mon, 18 Dec 2023 19:01:41 -0800
- To: w3c/gamepad <gamepad@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Tuesday, 19 December 2023 03:01:47 UTC
@gabrielsanbrito commented on this pull request. > + <li>Let |effectPromise| be + [=this=].{{GamepadHapticActuator/[[playingEffectPromise]]}}. + </li> + <li>Set + [=this=].{{GamepadHapticActuator/[[playingEffectPromise]]}} to + `undefined`. + </li> + <li>[=Queue a global task=] on the [=relevant global object=] + of [=this=] using the [=gamepad task source=] to [=resolve=] + |effectPromise| with {{GamepadHapticsResult/"preempted"}}. + </li> + </ol> + </li> + <li>[=Stop haptic effects=] on this actuator. + </li> + <li>Return [=a promise resolved with=] I have made the changes to the `reset()` method so that we wait for some platform response. The vocabulary might be a little bit different in relation to `playEffect`, but I can adjust either for consistency. -- Reply to this email directly or view it on GitHub: https://github.com/w3c/gamepad/pull/190#discussion_r1430860412 You are receiving this because you are subscribed to this thread. Message ID: <w3c/gamepad/pull/190/review/1788019869@github.com>
Received on Tuesday, 19 December 2023 03:01:47 UTC