- From: Marcos Cáceres <notifications@github.com>
- Date: Thu, 14 Dec 2023 16:08:56 -0800
- To: w3c/gamepad <gamepad@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Friday, 15 December 2023 00:09:02 UTC
@marcoscaceres commented on this pull request.
> + |effectPromise| with {{GamepadHapticsResult/"preempted"}}.
+ </li>
+ </ol>
+ </li>
+ <li>If this actuator cannot [=play effects with type=] |type|,
+ return [=a promise rejected with=] reason {{NotSupportedError}}.
+ </li>
+ <li>Let {{GamepadHapticActuator/[[playingEffectPromise]]}} be [=a
+ new promise=].
+ </li>
+ <li>Do the following steps in parallel:
+ <ol>
+ <li>[=Issue a haptic effect=] to the actuator with |type| and
+ |params|.
+ </li>
+ <li>When the effect completes, if it was not preempted, [=queue
Let's change "if it was not preempted" to an explicit check for `GamepadHapticActuator/[[playingEffectPromise]]`
--
Reply to this email directly or view it on GitHub:
https://github.com/w3c/gamepad/pull/190#pullrequestreview-1782946569
You are receiving this because you are subscribed to this thread.
Message ID: <w3c/gamepad/pull/190/review/1782946569@github.com>
Received on Friday, 15 December 2023 00:09:02 UTC