- From: Marcos Cáceres <notifications@github.com>
- Date: Mon, 11 Dec 2023 21:37:42 -0800
- To: w3c/gamepad <gamepad@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Tuesday, 12 December 2023 05:37:48 UTC
@marcoscaceres commented on this pull request.
> + {{GamepadEffectParameters/strongMagnitude}} and
+ {{GamepadEffectParameters/weakMagnitude}} set the vibration
+ intensity levels for the low-frequency and high-frequency rumble
+ motors, normalized to the range `[0,1]`, default 0. An effect
+ with magnitude values outside of this range is not a [=valid
+ effect=].
As above... this should be generalized... it's not specific to "dual-rumble"
```suggestion
{{GamepadEffectParameters/strongMagnitude}} and
{{GamepadEffectParameters/weakMagnitude}} set the
intensity levels for the low-frequency and high-frequency vibrations,
normalized to the range `[0,1]`, defaulting to 0. An effect
with magnitude values outside of this range is not a [=valid
effect=].
```
The " An effect with magnitude values outside of this range is not a [=valid effect=]" should be checked as part of a valuation algorithm.
--
Reply to this email directly or view it on GitHub:
https://github.com/w3c/gamepad/pull/190#pullrequestreview-1776673280
You are receiving this because you are subscribed to this thread.
Message ID: <w3c/gamepad/pull/190/review/1776673280@github.com>
Received on Tuesday, 12 December 2023 05:37:48 UTC