Re: [w3c/gamepad] Move vibrationActuator to the main spec (PR #190)

@marcoscaceres commented on this pull request.



> +      </dl>
+      <p>
+        A {{GamepadHapticActuator}} can <dfn>play effects with type</dfn>
+        |type:GamepadHapticEffectType| if |type:GamepadHapticEffectType| can be
+        found in the {{GamepadHapticActuator/[[effects]]}} [=list=].
+      </p>
+      <p>
+        An effect with {{GamepadHapticEffectType}}
+        |type:GamepadHapticEffectType| and {{GamepadEffectParameters}}
+        |params:GamepadEffectParameters| describes a <dfn>valid effect</dfn> if
+        |params| contains all of the required parameters for |type| effects and
+        all of the parameters have valid values. Additional parameters MUST be
+        ignored.
+      </p>
+      <p>
+        A [=user agent=] that implements this API MUST provide a method to

This isn't right... The should just define should define what  `<dfn>issue a haptic effect</dfn>` with the parameters means, not that it's a MUST. The MUST part is already part of playEffect(), this just needs to say what to do "i.e., make the actuator render the |type| and try to make it use the |params|" (needs better wording, but you get the idea). 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/gamepad/pull/190#pullrequestreview-1776577838
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/gamepad/pull/190/review/1776577838@github.com>