Re: [w3c/gamepad] Move vibrationActuator to the main spec (PR #190)

@marcoscaceres commented on this pull request.



> +                <li>Let |effectPromise| be
+                [=this=].{{GamepadHapticActuator/[[playingEffectPromise]]}}.
+                </li>
+                <li>Set
+                [=this=].{{GamepadHapticActuator/[[playingEffectPromise]]}} to
+                `undefined`.
+                </li>
+                <li>[=Queue a global task=] on the [=relevant global object=]
+                of [=this=] using the [=gamepad task source=] to [=resolve=]
+                |effectPromise| with {{GamepadHapticsResult/"preempted"}}.
+                </li>
+              </ol>
+            </li>
+            <li>[=Stop haptic effects=] on this actuator.
+            </li>
+            <li>Return [=a promise resolved with=]

This doesn't feel right to me... it's returning the resolved promise without getting affirmation from the OS that the call to stop was sent and succeeded. I was expecting this to work the same as playEffect(). 


-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/gamepad/pull/190#pullrequestreview-1776573454
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/gamepad/pull/190/review/1776573454@github.com>