Re: [w3c/gamepad] Move vibrationActuator to the main spec (PR #190)

@marcoscaceres commented on this pull request.



> +            <li>If this actuator cannot [=play effects with type=] |type|,
+            return [=a promise rejected with=] reason {{NotSupportedError}}.
+            </li>
+            <li>Let {{GamepadHapticActuator/[[playingEffectPromise]]}} be [=a
+            new promise=].
+            </li>
+            <li>Do the following steps in parallel:
+              <ol>
+                <li>[=Issue a haptic effect=] to the actuator with |type| and
+                |params|.
+                </li>
+                <li>When the effect completes, if it was not preempted, [=queue
+                a global task=] on the [=relevant global object=] of [=this=]
+                using the [=gamepad task source=] to run the following steps:
+                  <ol>
+                    <li>[=Resolve=]

Should this assert or check that [=this=].{{GamepadHapticActuator/[[playingEffectPromise]]}} is not undefined? It could have gotten destroyed or it might not even be the same promise anymore, right? 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/gamepad/pull/190#pullrequestreview-1776568991
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/gamepad/pull/190/review/1776568991@github.com>