- From: Anne van Kesteren <notifications@github.com>
- Date: Thu, 24 Aug 2023 05:17:42 -0700
- To: whatwg/fetch <fetch@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 24 August 2023 12:17:49 UTC
@annevk commented on this pull request. > - See https://github.com/whatwg/fetch/issues/1552 for future work --> - <li><p>Let <var>contentRange</var> be `<code>bytes </code>`. - - <li><p>Append <var>rangeStart</var>, <a lt="serialize an integer">serialized</a> and - <a>isomorphic encoded</a>, to <var>contentRange</var>. - - <li><p>Append 0x2D (-) to <var>contentRange</var>. - - <li><p>Append <var>rangeEnd</var>, <a lt="serialize an integer">serialized</a> and - <a>isomorphic encoded</a> to <var>contentRange</var>. - - <li><p>Append 0x2F (/) to <var>contentRange</var>. - - <li><p>Append <var>serializedFullLength</var> to <var>contentRange</var>. + <li><p>Let <var>contentRange</var> be the result of invoking <a>build a content range</a> + given <var>rangeStart</var>, <var>rangeEnd</var>, and <var>slicedBlob</var>'s {{Blob/size}}. You go from serializedFullLength to serializedSlicedLength here. That seems wrong. -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/fetch/pull/1696#pullrequestreview-1593454711 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/fetch/pull/1696/review/1593454711@github.com>
Received on Thursday, 24 August 2023 12:17:49 UTC