- From: Peter Burns <notifications@github.com>
- Date: Wed, 16 Aug 2023 14:46:22 -0700
- To: WICG/webcomponents <webcomponents@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 16 August 2023 21:46:29 UTC
@rictic commented on this pull request. > ```js -const [firstName, lastName] = AttributePart.create(element, "title", null, [ - null, - " ", - null, -]); -// Syntax to be improved. Here, a new AttributePart is created between each string. +const part = AttributePart(document.getPartRoot(), element, "href"); +part.value = ["mailto: ", email]; `['', '']` may be more elegant, but `undefined` may be more performant, and I'd prefer the more performant option. No objection from me for `undefined` -- Reply to this email directly or view it on GitHub: https://github.com/WICG/webcomponents/pull/1023#discussion_r1296461487 You are receiving this because you are subscribed to this thread. Message ID: <WICG/webcomponents/pull/1023/review/1581466486@github.com>
Received on Wednesday, 16 August 2023 21:46:29 UTC