- From: Tom Wilkinson <notifications@github.com>
- Date: Wed, 09 Aug 2023 13:00:38 -0700
- To: WICG/webcomponents <webcomponents@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 9 August 2023 20:00:43 UTC
@tbondwilkinson commented on this pull request. > ```js -const [firstName, lastName] = AttributePart.create(element, "title", null, [ - null, - " ", - null, -]); -// Syntax to be improved. Here, a new AttributePart is created between each string. +const part = AttributePart(document.getPartRoot(), element, "href"); +part.value = ["mailto: ", email]; I updated the wording a bit in this section to more cleanly spell out how statics and values fit together. I'm not sure on statics = ['', ''] being the boundary condition. Why not just statics = undefined in the case where the AttributePart was created without statics? We can throw an Error during construction if someone tries to create an AttributePart with a static array that is less than 2 in length. -- Reply to this email directly or view it on GitHub: https://github.com/WICG/webcomponents/pull/1023#discussion_r1289132619 You are receiving this because you are subscribed to this thread. Message ID: <WICG/webcomponents/pull/1023/review/1570451149@github.com>
Received on Wednesday, 9 August 2023 20:00:43 UTC