- From: Mason Freed <notifications@github.com>
- Date: Fri, 30 Sep 2022 16:57:21 -0700
- To: whatwg/dom <dom@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Friday, 30 September 2022 23:57:34 UTC
@mfreed7 commented on this pull request. > @@ -4185,8 +4185,8 @@ elements. SVG ought to do the same for its <{script}> elements, but does not cal at the moment. <p>To <dfn export id=concept-node-clone lt="clone a node" local-lt="clone">clone</dfn> a -<var>node</var>, with an optional <var>document</var> and <i>clone children flag</i>, run these -steps: +<var>node</var>, with an optional <var>document</var>, <i>clone children flag</i>, and +<i>clone shadows flag</i>, run these steps: Ahh I see. I suppose that would work, but then you'd have a special case in the **parser** rather than just here in the cloning code, right? I'd always prefer to avoid adding more special cases to the parser if possible. -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/dom/pull/892#discussion_r985006374 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/dom/pull/892/review/1127436562@github.com>
Received on Friday, 30 September 2022 23:57:34 UTC