Re: [whatwg/fetch] Add abort reason to abort fetch (PR #1343)

@nidhijaju commented on this pull request.



> @@ -7784,9 +7803,21 @@ method steps are:
   <ol>
    <li><p>If <var>locallyAborted</var> is true, terminate these substeps.
 
-   <li><p>If <var>response</var>'s <a for=response>aborted flag</a> is set, then <a>abort fetch</a>
-   with <var>p</var>, <var>request</var>, and <var>responseObject</var>, and terminate these
-   substeps.
+   <li><p>If <var>response</var>'s <a for=response>aborted flag</a> is set, then:

Good point, I've updated the erroring stream bit.

With regards to the latter part, I guess the reason why we don't use the abort reason on the controller here is because we need to abort the controller first which we do in Step 12.2.4 which in turn sets the serialized abort reason on the controller. Do you mean more that the controller does not need to be aborted since it should already be aborted at that point?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1343#discussion_r983002814
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/fetch/pull/1343/review/1124545065@github.com>