Re: [whatwg/fetch] Pass in response status to mark resource timing (PR #1468)

@annevk commented on this pull request.

If you rebase this I think Build will succeed again. There was a temporary issue that is now resolved.

> +     <a>same origin</a> with <var>request</var>'s <a for=request>origin</a>, and
+     <var>response</var>'s <a for=response>status</a> otherwise.

The style we try to follow (see Infra) is like this:

> origin; otherwise _response_'s status.

> +     <li><p>Let <var>responseStatus</var> be 0 if <var>fetchParams</var>'s
+     <a for="fetch params">request</a>'s <a for=request>mode</a> is "<code>navigate</code>" and
+     <var>response</var>'s <a for=response>URL</a>'s <a for=url>origin</a> is not
+     <a>same origin</a> with <var>request</var>'s <a for=request>origin</a>, and
+     <var>response</var>'s <a for=response>status</a> otherwise.

I don't think the same origin check here is good. This doesn't take redirects into account.

Also, is this the internal response or not?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1468#pullrequestreview-1120085288
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/fetch/pull/1468/review/1120085288@github.com>