Re: [whatwg/fetch] Add support for parsing a suffix byte range spec (PR #1454)

@annevk commented on this pull request.

This looks great! Couple nits left. I'm happy to address those myself, but I wanted your take on them before going ahead.

> @@ -1077,14 +1083,14 @@ run these steps:
  <li><p>Return <var>values</var>.
 </ol>
 
-<p>To determine if a <a>byte sequence</a> <var>value</var> is a
-<dfn>simple range header value</dfn>, perform the following steps. They return a <a>boolean</a>.
+<p>To <dfn lt="parse a single range header value|simple range header value">parse a single range header value</dfn>

```suggestion
<p>To <dfn id=simple-range-header-value>parse a single range header value</dfn>
```

>  </ol>
 
-<p class="note">A <a>simple range header value</a> is a subset of allowed range header values, but
-it is the most common form used by user agents when requesting media or resuming downloads. This
-format of range header value can be set using <a>add a range header</a>.
+<p class="note"><a>parse a single range header value</a> succeeds for a subset of allowed range

```suggestion
<p class="note"><a>Parse a single range header value</a> succeeds for a subset of allowed range
```

> +   <dd>
+    <ol>
+     <li><p>Let <var>rangeResult</var> be the result of <a>parse a single range header value</a>
+     given <var>value</var>.
+
+     <li><p>If <var>rangeResult</var> is failure, then return false.
+    </ol>

Optional: yours is okay, but I think it's also simple enough still we could shorten it to:
```suggestion
   <dd><p>If the result of <a>parse a single range header value</a> given <var>value</var> is
   failure, then return false.
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1454#pullrequestreview-1118593865
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/fetch/pull/1454/review/1118593865@github.com>