Re: [whatwg/webidl] pp-webidl fails on Review Drafts (Issue #1195)

Yes, it's a result of `Slim Build Artifact`. It has effects in a few places:

```
/usr/local/google/home/tabatkins/bikeshed/bikeshed/highlight.py:
   34  
   35  def addSyntaxHighlighting(doc: t.SpecT) -> None:
   36:     if doc.md.slimBuildArtifact:
   37          return
   38      normalizeHighlightMarkers(doc)

/usr/local/google/home/tabatkins/bikeshed/bikeshed/unsortedJunk.py:
  266  
  267  def addVarClickHighlighting(doc: t.SpecT) -> None:
  268:     if doc.md.slimBuildArtifact:
  269          return
  270      doc.extraStyles[
  ...
  968  def decorateAutolink(doc: t.SpecT, el: t.ElementT, linkType: str, linkText: str, ref: refs.RefWrapper) -> None:
  969      # Add additional effects to autolinks.
  970:     if doc.md.slimBuildArtifact:
  971          return
  972  
  ...
 1058  
 1059  def addSelfLinks(doc: t.SpecT) -> None:
 1060:     if doc.md.slimBuildArtifact:
 1061          return
 1062  
 ....
 1306              el.set("data-noexport", "")
 1307  
 1308:         if doc.md.slimBuildArtifact:
 1309              # Remove *all* data- attributes.
 1310              for attrName in el.attrib:

/usr/local/google/home/tabatkins/bikeshed/bikeshed/idl.py:
  330          h.addClass(el, "highlight")
  331          highlightingOccurred = True
  332:     if doc.md.slimBuildArtifact:
  333          # Remove the highlight-only spans
  334          for el in idlEls:
```

Notably, it prevents or removes highlighting, a few other assorted "human-readability" effects, and also removes all of the `data-*` attributes that Bikeshed uses thruout to signal various things.  So if your script is depending on such a `data-*` attribute to exist, it'll fail.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/webidl/issues/1195#issuecomment-1254103120
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/webidl/issues/1195/1254103120@github.com>

Received on Wednesday, 21 September 2022 18:57:33 UTC