Re: [whatwg/webidl] Normative: Add DOMException cause (PR #1179)

@domenic commented on this pull request.

Looking good with small issues.

> @@ -14601,19 +14608,28 @@ requirements beyond the normal ones for [=interface types=].
 Each {{DOMException}} object has an associated <dfn for="DOMException">name</dfn> and
 <dfn for="DOMException">message</dfn>, both [=strings=].
 
+Each {{DOMException}} object has an associated <dfn for="DOMException">cause</dfn>, which
+is a JavaScript value. It is {{undefined}} unless specified otherwise.

```suggestion
is a JavaScript value. It is <emu-val>undefined</emu-val> unless specified otherwise.
```

>  constructor steps are:
 
-1. Set [=this=]'s [=DOMException/name=] to |name|.
-1. Set [=this=]'s [=DOMException/message=] to |message|.
+1.  Set [=this=]'s [=DOMException/message=] to |message|.
+1.  If |options| is a string, then set [=this=]'s [=DOMException/name=] to |options|.
+1.  Otherwise,
+    1.  Set [=this=]'s [=DOMException/name=] to |options|["{{DOMExceptionOptions/name}}"].
+    1.  Set [=this=]'s [=DOMException/cause=] to |options|["{{DOMExceptionOptions/cause}}"].

You have to handle the case where `|options|["{{DOMExceptionOptions/cause}}"]` does not `[=map/exist=]`.

A proposal to make this easier is https://github.com/whatwg/webidl/issues/983 but it is not available yet.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/webidl/pull/1179#pullrequestreview-1098825084
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/webidl/pull/1179/review/1098825084@github.com>