Re: [whatwg/fetch] Editorial: Use controller for navigation redirect (PR #1469)

@annevk commented on this pull request.

How does this work in terms of callbacks and such? The prior approach was that the algorithm would return a response. I'm not entirely sure that was workable, but I'm not sure what the new approach is.

> @@ -4766,7 +4779,10 @@ these steps:
 
      <dt>"<code>manual</code>"
      <dd><p>Set <var>response</var> to an <a>opaque-redirect filtered response</a> whose
-     <a for="filtered response">internal response</a> is <var>actualResponse</var>.
+     <a for="filtered response">internal response</a> is <var>actualResponse</var>, and set
+     <var>fetchParams</var>'s <a for="fetch params">controller</a>'s <a
+     for="fetch controller">next redirect steps</a> to run <a>HTTP-redirect fetch</a> given
+     <var>fetchParams</var> and <var>response</var>.

We should only do this when mode is "navigate".

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1469#pullrequestreview-1094775535
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/fetch/pull/1469/review/1094775535@github.com>