- From: Marcos Cáceres <notifications@github.com>
- Date: Mon, 31 Oct 2022 02:07:27 -0700
- To: w3c/screen-orientation <screen-orientation@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Monday, 31 October 2022 09:07:40 UTC
@marcoscaceres commented on this pull request. > + being [=Document/fully active=] while [=in parallel=], and if the + |document|'s {{Document/[[orientationPendingPromise]]}} is not `null`, + [=reject and nullify the current lock promise=] of |document| with an + {{"AbortError"}}: Yeah, understood. Do you think the intention is clear enough though? It's not too dissimilar to, for instance, in img decode9() method. It also has similar wording: > This [img](https://html.spec.whatwg.org/#the-img-element) element's [node document](https://dom.spec.whatwg.org/#concept-node-document) stops being [fully active](https://html.spec.whatwg.org/#fully-active) >... other cases... >Reject promise with an ["EncodingError"](https://webidl.spec.whatwg.org/#encodingerror) [DOMException](https://webidl.spec.whatwg.org/#dfn-DOMException). -- Reply to this email directly or view it on GitHub: https://github.com/w3c/screen-orientation/pull/236#discussion_r1009177606 You are receiving this because you are subscribed to this thread. Message ID: <w3c/screen-orientation/pull/236/review/1161536470@github.com>
Received on Monday, 31 October 2022 09:07:40 UTC