- From: Marcos Cáceres <notifications@github.com>
- Date: Sun, 30 Oct 2022 17:56:20 -0700
- To: w3c/screen-orientation <screen-orientation@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Monday, 31 October 2022 00:56:32 UTC
@marcoscaceres commented on this pull request.
> + being [=Document/fully active=] while [=in parallel=], and if the
+ |document|'s {{Document/[[orientationPendingPromise]]}} is not `null`,
+ [=reject and nullify the current lock promise=] of |document| with an
+ {{"AbortError"}}:
Thinking out loud... this is the only case we can realistically capture:
```JS
const iframe = document.querySelector("iframe");
const p = iframe.contentWindows.screen.orientation.lock("landscape");
iframe.remove();
// p aborts
```
So, the check should happen as the very first thing after going "in parallel".
--
Reply to this email directly or view it on GitHub:
https://github.com/w3c/screen-orientation/pull/236#discussion_r1008959662
You are receiving this because you are subscribed to this thread.
Message ID: <w3c/screen-orientation/pull/236/review/1161228486@github.com>
Received on Monday, 31 October 2022 00:56:32 UTC