[w3c/screen-orientation] "reject and nullify the current lock promise" nit (Issue #233) from Anne van Kesteren on 2022-10-27 (public-webapps-github@w3.org from October 2022)

From: Anne van Kesteren <notifications@github.com>
Date: Thu, 27 Oct 2022 05:31:24 -0700
To: w3c/screen-orientation <screen-orientation@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <w3c/screen-orientation/issues/233@github.com>

Most callers do a null check but this algorithm does one too. Either make an assert in the algorithm that it's not null and fix the remaining caller, or simplify the callers. The current combination is a tad confusing.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/screen-orientation/issues/233
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/screen-orientation/issues/233@github.com>

Received on Thursday, 27 October 2022 12:31:36 UTC