Re: [whatwg/dom] Adoption and DocumentFragment, part two (#819)

@annevk commented on this pull request.



> + <li>
+  <p>If <var>node</var> is a {{DocumentFragment}} <a for=/>node</a> and its
+  <a for=DocumentFragment>host</a> is non-null, then return <var>node</var>.
+
+  <p class=note>Unfortunately this does not throw for web compatibility.

@bigopon before this change `adoptNode()` would have returned undefined which would result in undefined behavior as its IDL claims its return value is a `Node`.

From reading the issue you linked it seems that implementations never matched the specification and some applications (such as yours) relied on that. Perhaps we need to continue to allow that, but it would be a strange special case for `HTMLTemplateElement`'s `DocumentFragment` usage as we cannot do the same thing if you were to pass a `ShadowRoot` for instance. It would also result in a rather weird `HTMLTemplateElement` instance, but since nothing much builds upon it maybe that is okay.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/819#discussion_r1005846877
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/dom/pull/819/review/1156775875@github.com>