Re: [whatwg/fetch] Editorial: WebSockets has its own standard now (PR #1516)

@domenic commented on this pull request.



> @@ -805,8 +802,8 @@ A: 3
  <li><p>Otherwise, <a for=list>append</a> (<var>name</var>, <var>value</var>) to <var>list</var>.
 </ol>
 
-<p class="note no-backref"><a for="header list">Combine</a> is used by {{XMLHttpRequest}} and the
-<a lt="establish a WebSocket connection">WebSocket protocol handshake</a>.
+<p class=note><a for="header list">Combine</a> is used by {{XMLHttpRequest}} and the
+<a spec=websockets lt="establish a WebSocket connection">WebSocket protocol handshake</a>.

This `spec=` shouldn't be necessary, here and below. It pierces the `export=""` barrier so is generally bad.

I guess it is necessary for now since Bikeshed gets confused between Fetch and WebSockets as the link destination. But that's better fixed with link-defaults plus a TODO to remove them in the future, I believe.

> @@ -8316,6 +8169,14 @@ resource — for non-<a>CORS requests</a> as well as <a>CORS
 requests</a> — and do not use `<code>Vary</code>`.
 
 
+<h3 class=no-num id=websocket-protocol oldids=websocket-connections,websocket-opening-handshake,fail-the-websocket-connection,the-websocket-connection-is-established>WebSockets</h2>
+
+<p class=note>Fetch used to define

A section with only a note looks strange. Maybe just make this a normal paragraph.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1516#pullrequestreview-1155739421

You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/fetch/pull/1516/review/1155739421@github.com>