- From: Marcos Cáceres <notifications@github.com>
- Date: Mon, 24 Oct 2022 19:29:16 -0700
- To: w3c/screen-orientation <screen-orientation@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/screen-orientation/pull/226/review/1154040373@github.com>
@marcoscaceres commented on this pull request.
For the exceptions, I'm passing just the name (DOMString) of the exception, and then contracting actual exception in the algorithm.
> @@ -507,7 +506,7 @@ <h2>
</li>
<li>If |document|'s {{Document/[[orientationPendingPromise]]}} is not
`null`, [=reject and nullify the current lock promise=] of |document|
- with {{"AbortError"}}.
+ with an {{"AbortError"}} {{DOMException}}.
```suggestion
with an {{"AbortError"}}.
```
> </p>
<ol>
<li>If |document| stops being [=Document/fully active=] while [=in
parallel=], [=reject and nullify the current lock promise=] of
- |document| with an {{"AbortError"}}.
+ |document| with an {{"AbortError"}} {{DOMException}}.
```suggestion
|document| with an {{"AbortError"}}.
```
> @@ -711,12 +710,11 @@ <h2>
continue.
</li>
<li>[=Reject and nullify the current lock promise=] of |doc| with
- {{"AbortError"}}.
+ an {{"AbortError"}} {{DOMException}}.
```suggestion
an {{"AbortError"}}.
```
> @@ -726,7 +724,7 @@ <h2>
<ol>
<li>If the |document|'s {{Document/[[orientationPendingPromise]]}}
is not `null`, [=reject and nullify the current lock promise=] of
- |document| with {{"NotSupportedError"}}.
+ |document| with a {{"NotSupportedError"}} {{DOMException}}.
```suggestion
|document| with a {{"NotSupportedError"}}.
```
> </p>
<ol class="algorithm">
<li>If |document|'s {{Document/[[orientationPendingPromise]]}} is not
`null`, [=reject and nullify the current lock promise=] of |document|
- with {{"AbortError"}}.
+ with an {{"AbortError"}} {{DOMException}}.
```suggestion
with an {{"AbortError"}}.
```
--
Reply to this email directly or view it on GitHub:
https://github.com/w3c/screen-orientation/pull/226#pullrequestreview-1154040373
You are receiving this because you are subscribed to this thread.
Message ID: <w3c/screen-orientation/pull/226/review/1154040373@github.com>
Received on Tuesday, 25 October 2022 02:29:28 UTC