- From: Anne van Kesteren <notifications@github.com>
- Date: Mon, 24 Oct 2022 09:18:42 -0700
- To: whatwg/fetch <fetch@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Monday, 24 October 2022 16:18:54 UTC
@annevk commented on this pull request. > - <li><p>If <var>controller</var> is not null, then <a for="fetch controller">abort</a> - <var>controller</var> with <var>requestObject</var>'s <a for=Request>signal</a>'s - <a for=AbortSignal>abort reason</a>. + <li><p><a for="fetch controller">Abort</a> <var>controller</var> with <var>requestObject</var>'s + <a for=Request>signal</a>'s <a for=AbortSignal>abort reason</a>. It doesn't actually work for blobs I think because the reading from disk happens in parallel from that. And we don't abort that stream. So I suspect we need to keep all the original invocations. I should probably start a new PR that only does some minor cleanup and perhaps explains how this works. We should probably also inline the "abort when" thing as a single check at the start of scheme fetch seems sufficient? -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/fetch/pull/1187#discussion_r1003510117 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/fetch/pull/1187/review/1153424606@github.com>
Received on Monday, 24 October 2022 16:18:54 UTC