Re: [whatwg/url] Reject non-IPv4 hostnames that end in numbers. (#619)

I'm sorry that this hit you, but end user security is our highest priority.  We don't like breaking things for developers - I mean, we are human, and we don't like making folks (justifiably) unhappy.  Breakages are sometimes inevitable, unfortunately, due to the cobbled-together nature of web standards, which often didn't take security into consideration, or overlook how features interact with each other.

In terms of modifying Chromium: Note that the commit that changed behavior had to completely refactor a method, because the new behavior required extra checking not present in the old code.  So you could perhaps come up with a smaller change in terms of production code to make the new code behave like the old code (I think it's the "if (family != CanonHostInfo::IPV4)" block?  It's pretty ugly code, unfortunately).  The rest of the CL was tests, which, yes, you'd need to revert, if you run tests and want them to pass.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/url/pull/619#issuecomment-1288193786
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/url/pull/619/c1288193786@github.com>