Re: [whatwg/dom] Add pop-up light dismiss logic to event dispatching (PR #1117) from Anne van Kesteren on 2022-10-18 (public-webapps-github@w3.org from October 2022)

From: Anne van Kesteren <notifications@github.com>
Date: Tue, 18 Oct 2022 02:32:35 -0700
To: whatwg/dom <dom@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <whatwg/dom/pull/1117/review/1145432980@github.com>

@annevk commented on this pull request.



> +     <li><p>Run {light dismiss open pop-ups} given <var>struct</var>'s <a
+     for=Event/path>invocation target</a>.

This needs some kind of note explaining the setup. This also seems like a layering violation. Is this really supposed to happen for all events or just certain UI events? Is it supposed to happen for synthetic events or just events dispatched by the user agent?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/1117#pullrequestreview-1145432980
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/dom/pull/1117/review/1145432980@github.com>

Received on Tuesday, 18 October 2022 09:32:48 UTC