- From: Marcos Cáceres <notifications@github.com>
- Date: Fri, 14 Oct 2022 01:01:51 -0700
- To: w3c/screen-orientation <screen-orientation@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Friday, 14 October 2022 08:02:03 UTC
@marcoscaceres commented on this pull request.
> + </p>
+ <ol>
+ <li>Restrict the value return by the {{ScreenOrientation/type}}
+ attribute to {{OrientationType/"portrait-primary"}} or
+ {{OrientationType/"landscape-secondary"}} to match the screen's aspect
+ ratio.
+ </li>
+ <li>Always return `0` for the value of the {{ScreenOrientation/angle}}
+ attribute.
+ </li>
+ <li>If the screen orientation changes, only fire the
+ <a data-link-for="ScreenOrientation">change</a> event when the
+ [=current orientation type=] changes from [=portrait=] to
+ [=landscape=], or vice versa. This both protects user's privacy by
+ not revealing how a device is being held, and prevents using the
+ [=secondary=] orientation as a fingerprinting vector.
oh lol, yes, that was a typo above.
--
Reply to this email directly or view it on GitHub:
https://github.com/w3c/screen-orientation/pull/215#discussion_r995467551
You are receiving this because you are subscribed to this thread.
Message ID: <w3c/screen-orientation/pull/215/review/1141995366@github.com>
Received on Friday, 14 October 2022 08:02:03 UTC