- From: Marcos Cáceres <notifications@github.com>
- Date: Thu, 13 Oct 2022 21:47:21 -0700
- To: w3c/screen-orientation <screen-orientation@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Friday, 14 October 2022 04:47:34 UTC
@marcoscaceres commented on this pull request. > + </li> + <li>Let |newAngle| be the corresponding angle from the <a>screen + orientation values table</a>. + </li> + <li>If |newType| and |newAngle| are equal to |document|'s [=associated + `Screen`=]'s {{ScreenOrientation}}'s {{ScreenOrientation/[[type]]}} and + {{ScreenOrientation/[[angle]]}} respectively, terminate these steps. + </li> + <li>[=Queue a task=] to on the [=DOM manipulation task source=] to: + <ol> + <li>Let |screen| |document|'s [=relevant global object=]'s + [=associated `Screen`=]. + </li> + <li>Set |screen|'s {{ScreenOrientation/[[angle]]}} to |newAngle|. + </li> + <li>Set |screen|'s {{ScreenOrientation/[[angle]]}} to |type|. ```suggestion <li>Set |screen|'s {{ScreenOrientation/[[angle]]}} to |newType|. ``` -- Reply to this email directly or view it on GitHub: https://github.com/w3c/screen-orientation/pull/220#pullrequestreview-1141809459 You are receiving this because you are subscribed to this thread. Message ID: <w3c/screen-orientation/pull/220/review/1141809459@github.com>
Received on Friday, 14 October 2022 04:47:34 UTC